Refactor graviton usage #628

tzaffi · 2022-12-31T16:12:30Z

This is a companion PR to Graviton's refactoring PR: algorand/graviton#45

Summary of changes

With Graviton's DryRunExecutor no longer segregating executions by mode, class _MatchMode became obsolete and so was removed
Rename PytealDryRunExecutor executions methods to dryrun_one and dryrun_sequence for clear correspondence with gravition.DryRunExecutor's run_one and run_sequnce methods.
Pass thru all run-time parameters available in the DryRunExecutor.run_* methods, from their corresponding PytealDryRunExecutor methods.
Remap imports because of new locations and names of various graviton classes

Q: What's missing from this PR?

ABI-Router Testability

Q: Which PR has that?

Graviton 4 abi router #634

* adding program page related ops

* Add Replace * Remove replace auto-import * Use scripts/generate_init.py * Add more tests to replace, substring, and extract (#1) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* Add Block # Conflicts: # pyteal/ir/ops.py * Disable flake8 errors on formatted lines * Add past version failure check * Remove unnecessary ignore Expr equality context

* Add JsonRef * Use named class methods to specify value type * Remove unnecessary ignore Expr equality context * Fix docstring link

* Add Base64Decode * Remove unnecessary ignore Expr equality context

* Support Secp256r1 curve * Fix type errors in ecdsa tests * Fix typo * Test Secp256k1 curve against TEAL 5 instead * Add compile check to `MultiValue` class * Use `MultiValue` compile checks instead of inheritance

* Add VrfVerify # Conflicts: # pyteal/ast/__init__.py # pyteal/ir/ops.py * Tidy with `MultiValue`’s compile check

* Add sha3_256 * Add crypto docs

* Add first valid time factory and update min version * Include FirstValidTime in txn tests * Add transaction field docs

* Add ed25519verify_bare * Fix typos in Ed25519 docstrings (#2) * Add crypto doc for Ed25519Verify_Bare Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* add box ops * full support on ops * first set of test, add versioning in multi * remove some seemingly not necessary code? * update testcase * check invalid arguments * finish testcase * move stuffs to app * version check trick * verifyTealVersion apply * error message * update docs structures * period * update doc * update doc * update doc * per pr review on implementation * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * hex box size goes wild * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * warning about MBR * wording * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * emphasize * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * Update docs/state.rst Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> * polishing * remove redundant box_put doc segment * per zeph pr review * use note and warning * per zeph's pr review * Update docs/state.rst Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * creating boxes * Update docs/state.rst Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * per pr review * table for state types Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Zeph Grunschlag <tzaffi@users.noreply.github.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

* swapping base64 modes to match the rest (#446) * Merge master into teal7 (#450) * AVM 7: Address integration branch feedback (#452) * Add Execute Method (#444) * adding execute method to allow omission of begin/submit for common use case * exec docstring * update testcase Co-authored-by: Hang Su <hang.su@algorand.com> * Merge branch 'master' into teal7 (#463) * fix misspelling of uint (#431) * fix misspelling of uint * Clarify minimum Python version management docs (#435) * Foreign prefix on App and Asset arrays (#440) * replacing foreignapps with applications * fix assets as well * Add Execute Method (#444) * adding execute method to allow omission of begin/submit for common use case * exec docstring * update testcase Co-authored-by: Hang Su <hang.su@algorand.com> Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Hang Su <hang.su@algorand.com> * Consolidate TEAL and AVM versioning (#441) * fix misspelling of uint (#431) * fix misspelling of uint * Clarify minimum Python version management docs (#435) * Convert TEAL version references to program version by hand * Replace `teal#Options` with `avm#Options` * Deprecate `*_TEAL_VERSION` in favor of `*_PROGRAM_VERSION` * Fix docs typo Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * Minor `versions.rst` changes * Fix `verifyTealVersion` in new opcode files * Fix linter errors * Fix language discrepencies introduced by the merge * Remove incorrect avm replacement * Fix inconsistent language introduced by merge Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> * max program version Co-authored-by: Ben Guidarelli <ben.guidarelli@gmail.com> Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Jacob Daitzman <jdtzmn@gmail.com>

…/files (#488)

requirements.txt

tests/blackbox.py

ahangsu

Consider this approval after algorand/graviton#45 is finalized.

requirements.txt

barnjamin and others added 30 commits June 24, 2022 10:05

upping max teal version

d0f9d8d

adding program page related ops (#412)

749fb8c

* adding program page related ops

Add Replace (#413)

39a11c2

* Add Replace * Remove replace auto-import * Use scripts/generate_init.py * Add more tests to replace, substring, and extract (#1) Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Add Block (#415)

dd2c7ec

* Add Block # Conflicts: # pyteal/ir/ops.py * Disable flake8 errors on formatted lines * Add past version failure check * Remove unnecessary ignore Expr equality context

Add JsonRef (#417)

8c3d2a0

* Add JsonRef * Use named class methods to specify value type * Remove unnecessary ignore Expr equality context * Fix docstring link

Add Base64Decode (#418)

839b985

* Add Base64Decode * Remove unnecessary ignore Expr equality context

Support Secp256r1 curve (#423)

7cccdcb

* Support Secp256r1 curve * Fix type errors in ecdsa tests * Fix typo * Test Secp256k1 curve against TEAL 5 instead * Add compile check to `MultiValue` class * Use `MultiValue` compile checks instead of inheritance

Add VrfVerify (#419)

9a26fec

* Add VrfVerify # Conflicts: # pyteal/ast/__init__.py # pyteal/ir/ops.py * Tidy with `MultiValue`’s compile check

Add Sha3_256 (#425)

cc544aa

* Add sha3_256 * Add crypto docs

Support FirstValidTime transaction field (#424)

6e83ae6

* Add first valid time factory and update min version * Include FirstValidTime in txn tests * Add transaction field docs

Add Ed25519Verify_Bare (#426)

594e8e4

* Add ed25519verify_bare * Fix typos in Ed25519 docstrings (#2) * Add crypto doc for Ed25519Verify_Bare Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com>

Merge branch 'master' into avm8

0ba95e9

Merge branch 'master' into avm8

e9af25f

Merge branch 'master' into avm8

ed516f7

change according to https://github.com/algorand/go-algorand/pull/4323…

055c981

…/files (#488)

Merge branch 'master' into avm8-merge-master

bc78e39

Merge branch 'master' into avm8

2c2b7b2

Merge branch 'master' into avm8

61af648

Merge branch 'master' into avm8

5282726

Changes to avm8 docs (#546)

76010b2

Merge branch 'master' into avm8

d767c66

Support new AVM 8 account parameters (#555)

cc49a55

add frame ops to avm8 branch

1d7cd6a

specify FRAME_POINTER_VERSION in frame-op branch

49d169e

just the work of abi data schema

02f3775

squashed

e8c5d2c

change in round trip test, stop something blocking me

a044f80

update frame dig and proto use

6739c00

Zeph Grunschlag added 2 commits December 31, 2022 20:30

pass txn_params and verbose to graviton's runners

97aff37

don't re-instantiate the executor at every iteration

1f97e30

tzaffi mentioned this pull request Jan 1, 2023

Refactor DryRunExecutor algorand/graviton#40

Closed

14 tasks

tzaffi requested review from michaeldiamant and ahangsu January 1, 2023 15:33

tzaffi marked this pull request as ready for review January 1, 2023 15:33

Zeph Grunschlag added 2 commits January 1, 2023 11:40

remove now unused add_trace()

315fc23

lint

09261e8

tzaffi commented Jan 1, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

Update to requirements.txt to latest graviton commit

18150bc

tzaffi commented Jan 1, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

Zeph Grunschlag and others added 4 commits January 3, 2023 16:24

pin to graviton 0.7.0

69519c5

fix gravition pin

3ad2f2e

pin to v0.7.0

0ee255c

Typo fix in docs (#625)

ed1baf4

tzaffi mentioned this pull request Jan 3, 2023

Refactor DryRunExecutor algorand/graviton#45

Merged

1 task

tzaffi commented Jan 4, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

Merge branch 'graviton-identical-subroutines' into graviton-refac

251f0af

Base automatically changed from graviton-identical-subroutines to master January 11, 2023 16:04

Zeph Grunschlag added 3 commits January 12, 2023 19:31

Merge branch 'master' into graviton-refac

1f62233

flake8

fc06c17

🤞

3232a09

tzaffi commented Jan 17, 2023

View reviewed changes

tests/blackbox.py Outdated Show resolved Hide resolved

Trigger a build against head of depending graviton branch

d0331b0

ahangsu approved these changes Jan 17, 2023

View reviewed changes

Update requirements.txt

cf21e18

tzaffi commented Jan 17, 2023

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

correct repo

e355c93

tzaffi merged commit b4c3cdd into master Jan 17, 2023

tzaffi deleted the graviton-refac branch January 17, 2023 19:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor graviton usage #628

Refactor graviton usage #628

tzaffi commented Dec 31, 2022 •

edited

Loading

ahangsu left a comment

Refactor graviton usage #628

Refactor graviton usage #628

Conversation

tzaffi commented Dec 31, 2022 • edited Loading

Summary of changes

Q: What's missing from this PR?

Q: Which PR has that?

ahangsu left a comment

Choose a reason for hiding this comment

tzaffi commented Dec 31, 2022 •

edited

Loading