Skip to content

Conversation

aorumbayev
Copy link
Collaborator

@aorumbayev aorumbayev commented Apr 9, 2024

Proposed Changes

  • Remove a hotfix that was addressing outdated readme instructions to allow executing smart contracts module for deploy directly without using algokit project deploy. Later PRs improved the docs and direct running deploy directly is not longer incentivized by the quick start guide hence instead of always loading the .env.localnet - its left as a comment for more advanced users.
  • Hotfix behaviour was invalid as it was clashing with other env vars. @CiottiGiorgio reported that due to this statement, deploying to any other custom network would clash since by default we don't specify empty env vars for things like PORT, Token and etc for testnet/mainnet nodely api access (while hardcoded load of localnet would set localnet specific values that would clash).

@aorumbayev aorumbayev requested a review from neilcampbell April 9, 2024 10:42
@aorumbayev aorumbayev merged commit 4c7ba53 into main Apr 9, 2024
@aorumbayev aorumbayev deleted the chore/remove_hotfix branch April 9, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants