-
-
Notifications
You must be signed in to change notification settings - Fork 360
Added Monte Carlo Implementation in TI-83 BASIC #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Example code is also a visualization demo
Ahh, that explains why you wrote Monte Carlo in TI-BASIC, of all languages. |
lol thats my moniker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is kind of awkward. It's been a couple of months, but I finally ran your program. I tried to type it into my calculator and didn't find the GDB functions, said I'd do it the next day and.. well... forgot about it.
I tried to run this on a TI-82 and I had to tweak it a bit to make it work. I know you wrote this for the TI-83, but we might as well try to make the programs work on more devices.
::rand->Y | ||
::Pt-On(X,Y) | ||
::If ((X*X+Y*Y)<1) | ||
::Then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you did here and I have to admit that it makes it slightly more readable on a PC screen, but I ran into the issue that ::Then
breaks on my TI-82. Also, the colons make the line above long enough to be broken up into two, which decreases readability more than it's worth in my opinion. What do you think about getting rid of the colons?
Prompt M | ||
0->C | ||
0->I | ||
StoreGDB 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The StoreGDB function changed between the TI-82 and TI-83. On an 82 this has to be StoreGDB GDB1
instead. Do these GDB vars still exist on the 83? If not, then we'll keep it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how the GDB system works but I can confirm that those variables do still exist on my TI-84 Plus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking an unofficial changelog, there is nothing to suggest that these variables wouldn't be on a TI-83 either.
To anyone who wants to pick this PR up: |
This PR is almost ready to go. If anyone knows anything about TI83 and can change the few lines necessary (even in a separate PR), we can probably merge this. The implementation also needs to be added to the text |
Is this the code we want in the end?
|
@theinventor13 if you are ready to add your code to the relevant |
Example code is also a visualization demo