attempt at output standardization for approximate counting #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormofice
reviewed
Nov 4, 2021
There was a problem hiding this comment.
Hi, this looks good to me, however I have two small nitpicks regarding this PR.
Shouldn't the first line ("Counting Tests, 100 trials") also start with [#]\n, as its output should not be verified?
Also the python implementation includes a newline after the first line, which isn't present in the other implementations. This does not matter for automatic validation, as empty lines are skipped, but it seems like an unnecessary inconsistency.
|
Is this ready to be merged @stormofice |
stormofice
approved these changes
Nov 22, 2021
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #907 and was also mentioned in #898