Skip to content

add Go implementation of IFS #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add Go implementation of IFS #982

wants to merge 1 commit into from

Conversation

radu-munteanu
Copy link
Contributor

No description provided.

@radu-munteanu
Copy link
Contributor Author

Ref #789

@radu-munteanu
Copy link
Contributor Author

[lang: go]

@Amaras
Copy link
Member

Amaras commented Jan 1, 2022

Thanks for your PR, we will try to find a Go reviewer to review this as quickly as possible :)

Also, we paused the [lang: lang] GH action, so labeling is mostly manual again, sorry about that

@Amaras Amaras added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: go Go programming language labels Jan 1, 2022
henrikac
henrikac reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@henrikac henrikac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - easy to read and errors are being handled :)

@radu-munteanu
Copy link
Contributor Author

Good luck with AAA.

Amaras
Amaras approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it looks good to @henrikac, then it's good for me

@radu-munteanu radu-munteanu deleted the go-ifs branch January 3, 2022 14:53
@Amaras
Copy link
Member

Amaras commented Jan 3, 2022

Why was this closed before it was merged @radu-munteanu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikac henrikac henrikac left review comments

@Amaras Amaras Amaras approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) lang: go Go programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radu-munteanu @Amaras @henrikac