Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[networkx] Update the built-in app implementation to make the behavior consistent with NetworkX implementation #1176

Merged
merged 17 commits into from
Dec 20, 2021

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Dec 16, 2021

What do these changes do?

Update the built-in app implementation to make the behavior consistent with NetworkX implementation

Related issue number

Fixes #1182

@acezen acezen changed the title [networkx] Update the built-in app implementation to make the behavior identical to NetworkX implementation [networkx] Update the built-in app implementation to make the behavior consistent with NetworkX implementation Dec 17, 2021
@acezen acezen marked this pull request as ready for review December 17, 2021 02:38
from graphscope.nx.algorithms.builtin import hits_scipy
from graphscope.nx.algorithms.builtin import in_degree_centrality
from graphscope.nx.algorithms.builtin import node_boundary
from graphscope.nx.algorithms.builtin import out_degree_centrality
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #1176 (dfc3363) into main (8100c3b) will decrease coverage by 36.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1176       +/-   ##
===========================================
- Coverage   77.36%   40.49%   -36.87%     
===========================================
  Files          57      368      +311     
  Lines        5302    19677    +14375     
===========================================
+ Hits         4102     7969     +3867     
- Misses       1200    11708    +10508     
Impacted Files Coverage Δ
python/graphscope/dataset/ldbc.py 70.58% <0.00%> (-29.42%) ⬇️
python/graphscope/dataset/modern_graph.py 70.58% <0.00%> (-29.42%) ⬇️
python/graphscope/framework/graph_schema.py 61.25% <0.00%> (-14.33%) ⬇️
python/graphscope/framework/graph.py 80.00% <0.00%> (-12.24%) ⬇️
python/graphscope/framework/context.py 70.79% <0.00%> (-12.10%) ⬇️
python/graphscope/interactive/query.py 82.60% <0.00%> (-7.87%) ⬇️
python/graphscope/framework/utils.py 67.31% <0.00%> (-5.04%) ⬇️
python/graphscope/framework/graph_builder.py 88.23% <0.00%> (-4.27%) ⬇️
python/graphscope/client/rpc.py 80.99% <0.00%> (-4.20%) ⬇️
python/graphscope/framework/errors.py 91.80% <0.00%> (-3.79%) ⬇️
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a673a83...dfc3363. Read the comment docs.

@acezen acezen merged commit 76d4641 into alibaba:main Dec 20, 2021
@acezen acezen deleted the acezen/revise_builtin branch December 20, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NetworkX] make built-in apps behavior consistent with networkx algorithm
4 participants