Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the document of learning.Graph #1277

Merged
merged 13 commits into from
Jan 18, 2022
Merged

Improve the document of learning.Graph #1277

merged 13 commits into from
Jan 18, 2022

Conversation

acezen
Copy link
Collaborator

@acezen acezen commented Jan 18, 2022 •
edited

What do these changes do?

Related issue number

Fixes #1274

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022 •
edited

Codecov Report

Merging #1277 (6b9fb6e) into main (06e3392) will decrease coverage by 1.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1277      +/-   ##
==========================================
- Coverage   73.71%   72.49%   -1.23%     
==========================================
  Files          88       88              
  Lines        9493     9493              
==========================================
- Hits         6998     6882     -116     
- Misses       2495     2611     +116
Impacted Files Coverage Δ
python/graphscope/client/session.py 74.95% <ø> (ø)
python/graphscope/tests/unittest/test_java_app.py 55.00% <0.00%> (-45.00%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
python/graphscope/framework/app.py 89.44% <0.00%> (-0.51%) ⬇️
python/graphscope/client/rpc.py 85.95% <0.00%> (+0.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976345b...6b9fb6e. Read the comment docs.

sighingnow
sighingnow requested changes Jan 18, 2022
View reviewed changes
python/graphscope/learning/graph.py Outdated Show resolved Hide resolved
siyuan0322
siyuan0322 reviewed Jan 18, 2022
View reviewed changes
python/graphscope/learning/graph.py Outdated Show resolved Hide resolved
python/graphscope/learning/graph.py Outdated Show resolved Hide resolved
yecol
yecol requested changes Jan 18, 2022
View reviewed changes
python/graphscope/client/session.py Outdated Show resolved Hide resolved
python/graphscope/client/session.py Outdated Show resolved Hide resolved
python/graphscope/client/session.py Outdated Show resolved Hide resolved
python/graphscope/client/session.py Outdated Show resolved Hide resolved
yecol
yecol requested changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@yecol yecol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tools to check spelling and grammar.

@acezen
Copy link
Collaborator Author

acezen commented Jan 18, 2022 •
edited

The spell and grammar have been fixed, thanks for the review.

@siyuan0322 siyuan0322 self-requested a review January 18, 2022 11:00
@sighingnow sighingnow requested a review from yecol January 18, 2022 11:38
@siyuan0322 siyuan0322 merged commit e8f7aaf into alibaba:main Jan 18, 2022
@acezen acezen deleted the acezen/gle-doc branch January 18, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yecol yecol yecol approved these changes

@sighingnow sighingnow sighingnow approved these changes

@siyuan0322 siyuan0322 siyuan0322 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The document of graphscope.graphlearn is not clear
5 participants
@acezen @codecov-commenter @yecol @sighingnow @siyuan0322