Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to upgrade tinkerpop version to 3.5.1 in maxgraph #1349

Merged
merged 9 commits into from
Mar 18, 2022
Merged

Try to upgrade tinkerpop version to 3.5.1 in maxgraph #1349

merged 9 commits into from
Mar 18, 2022

Conversation

shirly121
Copy link
Collaborator

@shirly121 shirly121 commented Mar 2, 2022

What do these changes do?

1, upgrade tinkerpop under the interactive_engine from 3.4.12 to 3.5.1.
2, update codes of the compiler (used by groot and maxgraph) for some changes of interface in 3.5.1.
3, update unit tests of the compiler for the changes in 3.5.1.
4, update ci of groot and maxgraph by removing 7 blocking test cases.
5, ignore gaia tests in the ci procedure for we will replace it by ir.

Related issue number

Fixes

@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #1349 (b7f4850) into main (a314bbb) will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1349      +/-   ##
==========================================
- Coverage   73.55%   72.23%   -1.33%     
==========================================
  Files          88       88              
  Lines        9610     9610              
==========================================
- Hits         7069     6942     -127     
- Misses       2541     2668     +127     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 55.00% <0.00%> (-45.00%) ⬇️
python/graphscope/analytical/app/java_app.py 24.24% <0.00%> (-44.95%) ⬇️
python/graphscope/deploy/kubernetes/cluster.py 73.74% <0.00%> (-2.32%) ⬇️
python/graphscope/framework/utils.py 64.56% <0.00%> (-1.05%) ⬇️
python/graphscope/framework/app.py 89.44% <0.00%> (-0.51%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 69.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a314bbb...b7f4850. Read the comment docs.

@longbinlai longbinlai requested a review from yecol March 16, 2022 04:23
@longbinlai
Copy link
Collaborator

Could you please add more information for what this PR does? What has been done and why?

Copy link
Collaborator

@yecol yecol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check the changes on graphlearn.
It seems this PR should not introduce changes to it?

.github/workflows/gaia.yml Outdated Show resolved Hide resolved
@shirly121
Copy link
Collaborator Author

Could you please add more information for what this PR does? What has been done and why?

done

@longbinlai
Copy link
Collaborator

Please resolve the conflict @shirly121

@sighingnow
Copy link
Collaborator

/cc @shirly121 The pull request #1381 has been landed and you could rebase this PR against main and then resolve the conflicits.

@shirly121
Copy link
Collaborator Author

@shirly121 shirly121 closed this Mar 18, 2022
@shirly121 shirly121 reopened this Mar 18, 2022
@shirly121
Copy link
Collaborator Author

Please double check the changes on graphlearn. It seems this PR should not introduce changes to it?

It's a mistake, I have reverted the changes.

Copy link
Collaborator

@longbinlai longbinlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirly121 shirly121 merged commit c921cd6 into alibaba:main Mar 18, 2022
@shirly121 shirly121 deleted the upgrade_tinkerpop branch March 28, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants