-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to upgrade tinkerpop version to 3.5.1 in maxgraph #1349
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
- Coverage 73.55% 72.23% -1.33%
==========================================
Files 88 88
Lines 9610 9610
==========================================
- Hits 7069 6942 -127
- Misses 2541 2668 +127
Continue to review full report at Codecov.
|
Could you please add more information for what this PR does? What has been done and why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check the changes on graphlearn.
It seems this PR should not introduce changes to it?
done |
Please resolve the conflict @shirly121 |
/cc @shirly121 The pull request #1381 has been landed and you could rebase this PR against main and then resolve the conflicits. |
|
It's a mistake, I have reverted the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What do these changes do?
1, upgrade tinkerpop under the interactive_engine from 3.4.12 to 3.5.1.
2, update codes of the compiler (used by groot and maxgraph) for some changes of interface in 3.5.1.
3, update unit tests of the compiler for the changes in 3.5.1.
4, update ci of groot and maxgraph by removing 7 blocking test cases.
5, ignore gaia tests in the ci procedure for we will replace it by ir.
Related issue number
Fixes