Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAE-Java] Invoking GAE CI when CMakeLists.template changes #2101

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Sep 29, 2022

What do these changes do?

It is necessary to run GAE CI when CMakeLists.template is changed in pull request. As file will not be changed frequently, most pull requests' CI time will not be increased.

Related issue number

Fixes #2070

@zhanglei1949 zhanglei1949 changed the title [GAE-Java] Make gae CI invoked when CMakeLists.template changes [GAE-Java] Invoking GAE CI when CMakeLists.template changes Sep 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2101 (24a89d2) into main (e0a7615) will decrease coverage by 37.80%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2101       +/-   ##
===========================================
- Coverage   72.75%   34.94%   -37.81%     
===========================================
  Files          89       87        -2     
  Lines        9920     9883       -37     
===========================================
- Hits         7217     3454     -3763     
- Misses       2703     6429     +3726     
Impacted Files Coverage Δ
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
...aphscope/tests/kubernetes/test_resource_builder.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.00%) ⬇️
...on/graphscope/tests/kubernetes/test_demo_script.py 0.00% <0.00%> (-91.75%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.52%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0a7615...24a89d2. Read the comment docs.

@yecol yecol self-requested a review September 29, 2022 07:06
Copy link
Collaborator

@yecol yecol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments left in #2070

@sighingnow
Copy link
Collaborator

See the comments left in #2070

I have discussed with @zhanglei1949. This pull request is a "work around" for #2070, as we currently doesn't have a properly way to include the graphscope-demo.jar into the wheel package then run java app tests againist it.

@sighingnow sighingnow merged commit 5756de3 into alibaba:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Changes on GAE CMakeLists.template didn't invoke necessary CI Checks
4 participants