Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] GAE JavaDoc not generated #2206

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

zhanglei1949
Copy link
Collaborator

@zhanglei1949 zhanglei1949 commented Nov 7, 2022

The GAE Java doc not generated due to javadoc path error.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2022

Codecov Report

Merging #2206 (f911a89) into main (abdd5c9) will decrease coverage by 1.24%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2206      +/-   ##
==========================================
- Coverage   72.95%   71.71%   -1.25%     
==========================================
  Files          89       89              
  Lines        9789     9789              
==========================================
- Hits         7142     7020     -122     
- Misses       2647     2769     +122     
Impacted Files Coverage Δ
python/graphscope/tests/unittest/test_java_app.py 53.01% <0.00%> (-46.99%) ⬇️
python/graphscope/analytical/app/java_app.py 24.36% <0.00%> (-27.92%) ⬇️
python/graphscope/client/rpc.py 83.20% <0.00%> (-3.06%) ⬇️
python/graphscope/framework/graph_utils.py 80.15% <0.00%> (-2.39%) ⬇️
python/graphscope/client/session.py 74.95% <0.00%> (-1.52%) ⬇️
python/graphscope/framework/app.py 90.32% <0.00%> (-1.39%) ⬇️
python/graphscope/framework/utils.py 66.40% <0.00%> (-1.05%) ⬇️
python/graphscope/deploy/kubernetes/utils.py 69.52% <0.00%> (-0.96%) ⬇️
python/graphscope/framework/graph_schema.py 64.61% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4279b8f...f911a89. Read the comment docs.

@sighingnow
Copy link
Collaborator

Could you please add a --quite option to mvn in https://github.com/alibaba/GraphScope/blob/main/docs/Makefile#L42?

Thanks!

@zhanglei1949 zhanglei1949 force-pushed the update-doc branch 2 times, most recently from 8017ffd to 0d3dfea Compare November 8, 2022 02:56
@sighingnow sighingnow merged commit ed33b08 into alibaba:main Nov 8, 2022
@zhanglei1949 zhanglei1949 deleted the update-doc branch May 8, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants