[GAE-Java] Pack JNI lib libgrape-jni.so into grape-runtime.jar
#2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2330 +/- ##
==========================================
+ Coverage 40.03% 42.96% +2.92%
==========================================
Files 88 88
Lines 9714 9715 +1
==========================================
+ Hits 3889 4174 +285
+ Misses 5825 5541 -284
Continue to review full report at Codecov.
|
sighingnow
approved these changes
Dec 15, 2022
siyuan0322
approved these changes
Dec 15, 2022
| try { | ||
| NativeLoader.loadLibrary("grape-jni"); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
I wonder if the exception got swallowed is by purpose?
There was a problem hiding this comment.
Yes, we try to load jni library, but it is ok if failed.
zhanglei1949
force-pushed
the
main
branch
5 times, most recently
from
93e075a
to
6293d76
Compare
zhanglei1949
force-pushed
the
main
branch
2 times, most recently
from
ce04055
to
1bc9eb6
Compare
use native loader remove dst lib name in ffi class fix format remove comment in cmakelist try to fix graphx s s f s s add giraph jar to GRAPHSCOPE_HOME/lib shade pattern fix ci add giraph to class path automatically load grape_jvm_opts in java_loader_invoker catch class version inconsistent error fix lib loading and graph template parsing to load compile user so, user system.load fix python test format giraph jar needs when test giraph app fix giraph test s fix ci fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgrape-jni.sointogrape-runtime-shaded.jar.@FFIGen("grape-jni"), to avoid FastFFI generatingSystem.loadLibrary()code.