Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a filetype arguments in loader for reading orc/parquet using prefix #2332

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

See changes in loader.py.

Related issue number

Fixes #2328
Requires v6d-io/v6d#1104

@codecov-commenter
Copy link

Codecov Report

Merging #2332 (fd38523) into main (11c1715) will decrease coverage by 32.55%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2332       +/-   ##
===========================================
- Coverage   72.85%   40.29%   -32.56%     
===========================================
  Files          89       89               
  Lines        9956     9954        -2     
===========================================
- Hits         7253     4011     -3242     
- Misses       2703     5943     +3240     
Impacted Files Coverage Δ
python/graphscope/framework/loader.py 64.80% <100.00%> (-17.09%) ⬇️
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) ⬇️
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) ⬇️
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) ⬇️
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.19%) ⬇️
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-96.11%) ⬇️
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.00%) ⬇️
...hon/graphscope/tests/unittest/test_create_graph.py 0.00% <0.00%> (-92.73%) ⬇️
python/graphscope/tests/unittest/test_graph.py 0.00% <0.00%> (-85.47%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c1715...fd38523. Read the comment docs.

@sighingnow sighingnow force-pushed the ht/io-filetype branch 2 times, most recently from e5c18af to 291b92c Compare December 15, 2022 14:24
…refix

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow sighingnow merged commit c986ea3 into alibaba:main Dec 16, 2022
@sighingnow sighingnow deleted the ht/io-filetype branch December 16, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading from parquet/orc doesn's support loading from directory or using prefix
3 participants