Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage graphscope cli to build docker, and add arm64 based images #2341

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Leverage graphscope cli to build docker, and add arm64 based images #2341

merged 8 commits into from
Feb 9, 2023

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Dec 22, 2022 •
edited
Loading

Also fix #2274

@siyuan0322 siyuan0322 marked this pull request as draft December 22, 2022 14:55
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023 •
edited
Loading

Codecov Report

Merging #2341 (e36ca35) into main (670e481) will increase coverage by 32.08%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2341       +/-   ##
===========================================
+ Coverage   39.93%   72.01%   +32.08%     
===========================================
  Files          88       88               
  Lines        9771    10120      +349     
===========================================
+ Hits         3902     7288     +3386     
+ Misses       5869     2832     -3037
Impacted Files Coverage Δ
...on/graphscope/tests/kubernetes/test_demo_script.py 58.08% <50.00%> (-17.58%) ⬇️
python/graphscope/config.py 100.00% <100.00%> (ø)
python/graphscope/deploy/kubernetes/cluster.py 56.98% <0.00%> (-19.21%) ⬇️
python/graphscope/framework/dag.py 83.67% <0.00%> (+3.06%) ⬆️
python/graphscope/client/utils.py 86.66% <0.00%> (+3.63%) ⬆️
python/graphscope/analytical/app/java_app.py 28.93% <0.00%> (+4.56%) ⬆️
python/graphscope/client/session.py 74.93% <0.00%> (+9.13%) ⬆️
python/graphscope/client/rpc.py 84.32% <0.00%> (+10.44%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 670e481...e36ca35. Read the comment docs.

@siyuan0322 siyuan0322 marked this pull request as ready for review February 7, 2023 05:05
@siyuan0322 siyuan0322 changed the title use graphscope cli to build docker Leverage graphscope cli to build docker, and add arm platform images Feb 7, 2023
@siyuan0322 siyuan0322 changed the title Leverage graphscope cli to build docker, and add arm platform images Leverage graphscope cli to build docker, and add arm64 based images Feb 7, 2023
@siyuan0322
use graphscope cli to build docker
ecb4227 
use manylinux2014-ci-test

upgrade vineyard to 0.12.2

source graphscope_env
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023 •
edited
Loading

😭 Deploy PR Preview e36ca35 failed. Build logs

🤖 By surge-preview

@siyuan0322 siyuan0322 merged commit 7a48d25 into alibaba:main Feb 9, 2023
@siyuan0322 siyuan0322 deleted the zsy/docker-new branch February 9, 2023 02:26
@sighingnow sighingnow mentioned this pull request Mar 10, 2023
Closed
@acezen acezen mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yecol yecol yecol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-based environment for development on M1 processors
3 participants
@siyuan0322 @codecov-commenter @yecol