Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes louvain on projected fragment when v label is not 0 #2462

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

sighingnow
Copy link
Collaborator

What do these changes do?

With projected fragment, 0 may not be in the range of Vertices()/InnerVertices thus cannot be used as the index of vertex arrays.

Related issue number

Fixes #2446

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #2462 (08f221f) into main (6b1b6cf) will increase coverage by 33.28%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2462       +/-   ##
===========================================
+ Coverage   39.93%   73.22%   +33.28%     
===========================================
  Files          88       88               
  Lines        9771     9769        -2     
===========================================
+ Hits         3902     7153     +3251     
+ Misses       5869     2616     -3253     
Impacted Files Coverage Δ
python/graphscope/tests/conftest.py 86.39% <100.00%> (+38.86%) ⬆️
python/graphscope/tests/unittest/test_app.py 96.31% <100.00%> (+96.31%) ⬆️
python/graphscope/framework/dag.py 83.67% <0.00%> (+3.06%) ⬆️
python/graphscope/client/utils.py 86.66% <0.00%> (+3.63%) ⬆️
python/graphscope/analytical/app/java_app.py 28.93% <0.00%> (+4.56%) ⬆️
python/graphscope/client/rpc.py 84.32% <0.00%> (+10.44%) ⬆️
python/graphscope/framework/operation.py 87.67% <0.00%> (+10.95%) ⬆️
python/graphscope/client/session.py 77.38% <0.00%> (+11.58%) ⬆️
python/graphscope/framework/graph_schema.py 64.84% <0.00%> (+12.10%) ⬆️
python/graphscope/analytical/app/bfs.py 100.00% <0.00%> (+12.50%) ⬆️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b1b6cf...08f221f. Read the comment docs.

@sighingnow sighingnow merged commit e9850d3 into alibaba:main Feb 27, 2023
@sighingnow sighingnow deleted the ht/fix-louvain-projected branch February 27, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Louvain doesn't work on projected fragment on graph which has more than one vlabel
2 participants