Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-base to build out production images. Add another wheel tag dedicated for building wheels. #2607

Merged
merged 9 commits into from
May 5, 2023

Conversation

siyuan0322
Copy link
Collaborator

@siyuan0322 siyuan0322 commented Apr 14, 2023

What do these changes do?

🤖 Generated by Copilot at b5e9780

This pull request updates the base images, versions, and labels of various components of GraphScope to improve the compatibility, testing, and deployment of the project on kubernetes. It also simplifies the environment setup and fixes some dependency issues. The main files affected are .github/workflows/*, charts/gie-standalone/*, coordinator/*, and k8s/*.

🤖 Generated by Copilot at b5e9780

  • Update the version of vineyard from v0.13.4 to v0.14.0 in various files to align with the latest release of vineyard and its dependencies. (link, link, link, link)
  • Change the base image of graphscope-store and interactive-experimental-local-artifacts from centos:7.9.2009 to ubuntu:22.04 in the Dockerfiles to simplify the installation of dependencies and reduce the image size. (link, link)
  • Remove the lines to source the rh-python38 and devtoolset-8 environments from various files as they are not needed by the new base image of graphscope-store. (link, link, link)
  • Change the path of GraphScope from /opt/GraphScope to /opt/graphscope in the statefulset.yaml files for gie-standalone to follow the convention of using lowercase for directory names. (link, link)
  • Update the image of graphscope-dev from v0.13.4 to v0.14.0 in the gae and networkx-forward-algo-nightly workflows to use the latest version of graphscope and its dependencies for testing. (link, link)
  • Update the version of graphscope-client from 0.19.0 to 0.20.0 in the requirements.txt file for coordinator to align with the latest release of graphscope-client and its dependencies. (link)
  • Change the label of the self-hosted runner from manylinux2014 to manylinux2014-ci-test in various workflows to avoid conflicts with other workflows that use the same label. (link, link, link, link, link, link, link, link, link)
  • Add a line to fix the liblttng-ust0 dependency issue in the Dockerfile for manylinux to avoid the error of installing dotnet-sdk in the runner image. (link)
  • Add a new target for dev-wheel in the Makefile for k8s to build a graphscope-dev image with the wheel package for testing. (link)

Related issue number

Fixes N/A

@siyuan0322 siyuan0322 changed the title Zsy/dev Use ubuntu-base to build out production images. Add another wheel tag dedicated for building wheels. Apr 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #2607 (7e54bd8) into main (8168275) will increase coverage by 0.65%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
+ Coverage   72.95%   73.60%   +0.65%     
==========================================
  Files          98       98              
  Lines       10291    10302      +11     
==========================================
+ Hits         7508     7583      +75     
+ Misses       2783     2719      -64     
Impacted Files Coverage Δ
...n/graphscope/deploy/kubernetes/resource_builder.py 71.95% <100.00%> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8168275...7e54bd8. Read the comment docs.

sighingnow pushed a commit that referenced this pull request Apr 27, 2023
The error is
```
ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' 
module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017. See: 
urllib3/urllib3#2168
```

urllib3 release 2.0.0 today and dropped support for openssl < 1.1.1,
whereas out centos7 bundled openssl library is 1.0.2k.

This restraints could be dropped when our image base has been switch to
ubuntu #2607
rewrite all other dockerfiles to ubuntu based

use . instead of source operator
@siyuan0322 siyuan0322 merged commit 4225cb1 into alibaba:main May 5, 2023
@siyuan0322 siyuan0322 deleted the zsy/dev branch May 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants