Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support users to only input the kubeconfig path for connecting the k8s cluster #2799

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

dashanji
Copy link
Collaborator

@dashanji dashanji commented Jun 2, 2023

What do these changes do?

  • Support users to only input the kubeconfig path for connecting the k8s cluster
  • Get the current kubeconfig for vineyardctl.

Related issue number

Fixes #2796

…k8s cluster.

* Get the current kubeconfig for vineyardctl.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #2799 (9b24393) into main (191949b) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2799      +/-   ##
==========================================
- Coverage   73.22%   73.20%   -0.02%     
==========================================
  Files          99       99              
  Lines       10472    10474       +2     
==========================================
  Hits         7668     7668              
- Misses       2804     2806       +2     
Impacted Files Coverage Δ
python/graphscope/client/session.py 75.99% <50.00%> (-0.10%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e3007...9b24393. Read the comment docs.

@dashanji dashanji merged commit f1b216c into alibaba:main Jun 2, 2023
@dashanji dashanji deleted the fix-resolving-kubeconfig branch June 2, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fail to resolve the api client from a given kubeconfig
3 participants