Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(learning): Integrate GLTorch into GraphScope #3230

Merged
merged 17 commits into from
Sep 25, 2023
Merged

feat(learning): Integrate GLTorch into GraphScope #3230

merged 17 commits into from
Sep 25, 2023

Conversation

LiSu
Copy link
Collaborator

@LiSu LiSu commented Sep 18, 2023

This PR integrates GLTorch into GraphScope, allowing training GNNs using GLTorch in the local mode of GraphScope.

@LiSu LiSu marked this pull request as draft September 18, 2023 11:11
@LiSu LiSu changed the title [build(learning)] Integrate GLTorch into GraphScope build(learning): Integrate GLTorch into GraphScope Sep 20, 2023
@LiSu LiSu changed the title build(learning): Integrate GLTorch into GraphScope feat(learning): Integrate GLTorch into GraphScope Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #3230 (6c274d9) into main (7314f8c) will increase coverage by 24.13%.
The diff coverage is 20.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3230       +/-   ##
===========================================
+ Coverage   42.06%   66.20%   +24.13%     
===========================================
  Files         101      101               
  Lines       10987    11006       +19     
===========================================
+ Hits         4622     7286     +2664     
+ Misses       6365     3720     -2645     
Files Changed Coverage Δ
python/graphscope/client/session.py 66.72% <11.76%> (+0.46%) ⬆️
python/graphscope/client/rpc.py 71.01% <50.00%> (-2.71%) ⬇️
python/graphscope/__init__.py 83.33% <100.00%> (+0.47%) ⬆️

... and 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7314f8c...6c274d9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

🎊 PR Preview 6c274d9 has been successfully built and deployed to https://alibaba-graphscope-build-pr-3230.surge.sh

🤖 By surge-preview

@LiSu LiSu force-pushed the gltorch branch 2 times, most recently from e91a1ee to 1cb7b05 Compare September 22, 2023 06:41
@LiSu LiSu marked this pull request as ready for review September 22, 2023 08:15
@LiSu LiSu force-pushed the gltorch branch 3 times, most recently from f1d3c0c to 1f7a0b9 Compare September 25, 2023 05:48
@LiSu LiSu self-assigned this Sep 25, 2023
sighingnow
sighingnow previously approved these changes Sep 25, 2023
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

capture_output=True,
text=True,
)
import re
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe running cmake in a clean build directory would be better, i.e.,

build_dir = os.path.join(glt_root_path, 'cmake-build')
os.makedirs(build_dir, exist_ok=True)
output = subprocess.run([shutil.which('cmake'), '..'], cwd=build_dir, ....)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by adding a clean cmake build directory.

Zhanghyi and others added 14 commits September 25, 2023 14:31
…n_torch dataset and training on a single machine (#3156)

## What do these changes do?
This pr introduces the following changes:
1. A new graphlearn_torch API for session.
2. Add the script to launch the graphlearn_torch server with handle and
config.
3. Include an example of graphsage node classification with the
ogbn-arxiv dataset in GraphScope on a single machine.
## Related issue number
#3157
The dynamic world size feature in server-client mode has been
implemented in GLT, and this PR is used to update and use this feature.
)

For graphlearn_torch_vineyard, the cxx11_abi should be adjusted to the gcc environment. For graphlearn_torch, the cxx11_abi should always be set to false to match PyTorch.
fix lint issue
Add a tutorial for training PyG model.
Skip GLTorch link check
use json instead of pickle
Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The failure in Python test is irrelevant with this PR.

@LiSu LiSu merged commit 3374342 into main Sep 25, 2023
46 of 47 checks passed
@siyuan0322 siyuan0322 deleted the gltorch branch October 11, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants