-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(learning): Integrate GLTorch into GraphScope #3230
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
===========================================
+ Coverage 42.06% 66.20% +24.13%
===========================================
Files 101 101
Lines 10987 11006 +19
===========================================
+ Hits 4622 7286 +2664
+ Misses 6365 3720 -2645
... and 65 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🎊 PR Preview 6c274d9 has been successfully built and deployed to https://alibaba-graphscope-build-pr-3230.surge.sh 🤖 By surge-preview |
e91a1ee
to
1cb7b05
Compare
f1d3c0c
to
1f7a0b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
capture_output=True, | ||
text=True, | ||
) | ||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe running cmake in a clean build directory would be better, i.e.,
build_dir = os.path.join(glt_root_path, 'cmake-build')
os.makedirs(build_dir, exist_ok=True)
output = subprocess.run([shutil.which('cmake'), '..'], cwd=build_dir, ....)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by adding a clean cmake build directory.
…n_torch dataset and training on a single machine (#3156) ## What do these changes do? This pr introduces the following changes: 1. A new graphlearn_torch API for session. 2. Add the script to launch the graphlearn_torch server with handle and config. 3. Include an example of graphsage node classification with the ogbn-arxiv dataset in GraphScope on a single machine. ## Related issue number #3157
The dynamic world size feature in server-client mode has been implemented in GLT, and this PR is used to update and use this feature.
fix lint issues
fix lint issue
Add a tutorial for training PyG model.
Skip GLTorch link check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The failure in Python test is irrelevant with this PR.
This PR integrates GLTorch into GraphScope, allowing training GNNs using GLTorch in the local mode of GraphScope.