fix(analytical): Fix java sdk support for builtin libs #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Committed-by: xiaolei.zl from Dev container
lidongze0629
approved these changes
Jun 6, 2024
siyuan0322
reviewed
Jun 6, 2024
| @@ -73,7 +73,7 @@ RUN cd /home/graphscope/GraphScope/ && \ | |||
| strip ${INSTALL_DIR}/bin/grape_engine; \ | |||
| strip ${INSTALL_DIR}/lib/*.so; \ | |||
| sudo cp -rs ${INSTALL_DIR}/* ${GRAPHSCOPE_HOME}/; \ | |||
| python3 ./k8s/utils/precompile.py --graph --output_dir ${INSTALL_DIR}/builtin; \ | |||
| python3 ./k8s/utils/precompile.py --graph --output_dir ${INSTALL_DIR}/builtin --enable_java_sdk ON; \ | |||
There was a problem hiding this comment.
is this supposed to be in analytical-java.Dockerfile?
There was a problem hiding this comment.
Currently there is no analytical-java.Dockerfile. Should we create one? @siyuan0322
There was a problem hiding this comment.
Ohh this is in the analytical-java part. My fault.
siyuan0322
approved these changes
Jun 6, 2024
| @@ -73,7 +73,7 @@ RUN cd /home/graphscope/GraphScope/ && \ | |||
| strip ${INSTALL_DIR}/bin/grape_engine; \ | |||
| strip ${INSTALL_DIR}/lib/*.so; \ | |||
| sudo cp -rs ${INSTALL_DIR}/* ${GRAPHSCOPE_HOME}/; \ | |||
| python3 ./k8s/utils/precompile.py --graph --output_dir ${INSTALL_DIR}/builtin; \ | |||
| python3 ./k8s/utils/precompile.py --graph --output_dir ${INSTALL_DIR}/builtin --enable_java_sdk ON; \ | |||
There was a problem hiding this comment.
Ohh this is in the analytical-java part. My fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the built-in library compilation had no option to enable Java SDK support. This would cause Giraph apps to fail when loading graphs with
GiraphInputFormat.