Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix bugs in CI of GAIA on Vineyard #652

Merged
merged 2 commits into from
Aug 4, 2021
Merged

[Bug Fix] Fix bugs in CI of GAIA on Vineyard #652

merged 2 commits into from
Aug 4, 2021

Conversation

BingqingLyu
Copy link
Collaborator

@BingqingLyu BingqingLyu commented Aug 4, 2021

What do these changes do?

  1. fix bug in: g.V().has("author", "id", 2), where query is not processed by dataflow (since it only needs to query storage)
  2. fix bug in: g.V().has("author", "id", 2).out("writes"), by implementing get_property() and get_properties() as returning null results rather than unimplement!() for IdOnlyVertex in vineyard

Related issue number

#641

Copy link
Collaborator

@sighingnow sighingnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sighingnow sighingnow merged commit 36d7bc4 into alibaba:main Aug 4, 2021
@BingqingLyu BingqingLyu deleted the bug_fix branch August 4, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants