[ISSUE #2138] add the global exception handler, remove the duplicate try catch #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sczyh30
added
area/dashboard
cdfive
reviewed
Jun 4, 2021
...shboard/src/main/java/com/alibaba/csp/sentinel/dashboard/handler/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Jun 4, 2021
...shboard/src/main/java/com/alibaba/csp/sentinel/dashboard/handler/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
cdfive
reviewed
Jun 4, 2021
...shboard/src/main/java/com/alibaba/csp/sentinel/dashboard/handler/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
|
@cdfive I have solved the problems. could you help to review it again when you are free. tks. |
|
@brotherlu-xcq |
sczyh30
reviewed
Jun 7, 2021
| Map<String, String[]> params = webRequest.getParameterMap(); | ||
| String contextPath = getRequestPath(webRequest); | ||
| logger.error("[HandleExecutionException] Request failed, context path: {}, request params: {}, error: ", | ||
| contextPath, buildParamMessage(params), e); |
There was a problem hiding this comment.
Maybe e.getCause() is better here (for ExecutionException)?
There was a problem hiding this comment.
Hi @sczyh30 , I tried this. print the e will also print the cause exception. I think maybe we can keep it as now.
CST11021
pushed a commit
to CST11021/Sentinel
that referenced
this pull request
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fixes #2138
add the global exception handler, remove the duplicate try catch
Does this pull request fix one issue?
Fixes #2138
Describe how you did it
add GlobalExceptionHandler to catch the exception and format the error return.
Describe how to verify it
See the screenshot after change.
Special notes for reviews