Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: init support hgctl #273

Merged
merged 1 commit into from
Apr 4, 2023
Merged

feat: init support hgctl #273

merged 1 commit into from
Apr 4, 2023

Conversation

Xunzhuo
Copy link
Collaborator

@Xunzhuo Xunzhuo commented Apr 4, 2023 •
edited
Loading

Ⅰ. Describe what this PR did

Add init support for hgctl

  1. Refactor higress cmd
  2. Init support framework hgctl
  3. Add support for higress version
  4. Add support for hgctl version
  5. Make targets for hgctl

image

image

Ⅱ. Does this pull request fix one issue?

Xref: #229

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #273 (23455df) into main (0d4b8ee) will decrease coverage by 0.34%.
The diff coverage is 64.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   44.52%   44.19%   -0.34%     
==========================================
  Files          32       34       +2     
  Lines        5289     5311      +22     
==========================================
- Hits         2355     2347       -8     
- Misses       2766     2797      +31     
+ Partials      168      167       -1
Impacted Files Coverage Δ
pkg/cmd/root.go 0.00% <0.00%> (ø)
pkg/cmd/version.go 0.00% <0.00%> (ø)
pkg/cmd/server.go 84.21% <84.21%> (ø)

... and 2 files with indirect coverage changes

@Xunzhuo Xunzhuo force-pushed the feat-hgctl branch 5 times, most recently from 7672977 to 15de667 Compare April 4, 2023 07:06
@Xunzhuo Xunzhuo marked this pull request as ready for review April 4, 2023 07:16
@Xunzhuo Xunzhuo force-pushed the feat-hgctl branch 4 times, most recently from 62403ed to c2162a9 Compare April 4, 2023 08:28
@Xunzhuo
feat: init support hgctl
a0f26e0 
Signed-off-by: bitliu <bitliu@tencent.com>
@SpecialYang
Copy link
Collaborator

Great work. 👍🏻

johnlanni
johnlanni approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks

@johnlanni johnlanni merged commit a5edad1 into alibaba:main Apr 4, 2023
@Xunzhuo Xunzhuo mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlanni johnlanni johnlanni approved these changes

@SpecialYang SpecialYang Awaiting requested review from SpecialYang SpecialYang is a code owner

@Charlie17Li Charlie17Li Awaiting requested review from Charlie17Li

Assignees
No one assigned
Labels
area/hgctl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xunzhuo @codecov-commenter @SpecialYang @johnlanni