refactor: useUpdateEffect #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luchx
commented
Oct 18, 2019
luchx
commented
- remove useUpdateEffect of react-use
- add hook useUpdateEffect
merge umijs/hooks
- remove redundant arguments in useEffect
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/umijs/hooks/5elkvjtlo |
|
|
brickspert
approved these changes
Oct 20, 2019
| @@ -0,0 +1,7 @@ | |||
| import useUpdateEffect from '../index'; | |||
|
|
|||
| describe('useSearch', () => { | |||
src/useUpdateEffect/index.mdx
Outdated
|
|
||
| # useUpdateEffect | ||
|
|
||
| 一个作用于组件didMount阶段以后的 useEffect Hook。 |
|
文档这块，后面要重写的。 把这个分支合并到 docs 分支，然后分档需要根据新的规范重写。 |
ttys026
approved these changes
Oct 21, 2019
ttys026
pushed a commit
that referenced
this pull request
Oct 24, 2019
* feat: add useSelections * refactor: rewrite useSelections and add test * fix: fix test of useSelections * refactor: useUpdateEffect (#103) * feat: add useUpdateEffect * feat: useSelections add setSelected and add test * refactor: return object instead of array * feat: add demo for useSelections * docs: add document for useSelections * fix: fix demo of useSelections * feat: add usePagination * chore: add usePagination reference * fix: Put the function with same deps into one useMeno * feat: useAntdTable add sorter, filters * fix: deps error * fix: change halfSelected -> partiallySelected * fix: useAntdTable determine if filters are equal change to a more robust method * feat: add usePagination (#105) * feat: add usePagination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.