Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usePagination #105

Merged
merged 11 commits into from
Oct 24, 2019
Merged

feat: add usePagination #105

merged 11 commits into from
Oct 24, 2019

Conversation

brickspert
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Oct 22, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/umijs/hooks/5qanbrrzw
🌍 Preview: https://hooks-git-feat-usepagination.umijs.now.sh

@brickspert
Copy link
Collaborator Author

Is the name of this hooks usePagination not very good? maybe useAsyncPagination?

* feat: rename useControlledValue to useControllableValue
@awmleer
Copy link
Collaborator

awmleer commented Oct 22, 2019

image

master branch?🤔

@brickspert brickspert changed the base branch from master to feature October 22, 2019 08:26
@brickspert
Copy link
Collaborator Author

image

master branch?🤔

aha ~~ now, it's ok~

@brickspert
Copy link
Collaborator Author

#100 暂时没有支持 2,3点

@awmleer
Copy link
Collaborator

awmleer commented Oct 23, 2019

有个小疑问。。选中第3页,然后更改 pageSize ,这个时候需要把当前页重置为第1页么?

@brickspert
Copy link
Collaborator Author

有个小疑问。。选中第3页,然后更改 pageSize ,这个时候需要把当前页重置为第1页么?

不需要。但是如果 current 越界了,就要变成当前最大的 current。

@awmleer
Copy link
Collaborator

awmleer commented Oct 23, 2019

有个小疑问。。选中第3页,然后更改 pageSize ,这个时候需要把当前页重置为第1页么?

不需要。但是如果 current 越界了,就要变成当前最大的 current。

OK

@ttys026 ttys026 merged commit d37e391 into feature Oct 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/usePagination branch October 24, 2019 07:57
ttys026 pushed a commit that referenced this pull request Oct 24, 2019
* feat: add useSelections

* refactor: rewrite useSelections and add test

* fix: fix test of useSelections

* refactor: useUpdateEffect (#103)

* feat: add useUpdateEffect

* feat: useSelections add setSelected and add test

* refactor: return object instead of array

* feat: add demo for useSelections

* docs: add document for useSelections

* fix: fix demo of useSelections

* feat: add usePagination

* chore: add usePagination reference

* fix: Put the function with same deps into one useMeno

* feat: useAntdTable add sorter, filters

* fix: deps error

* fix: change halfSelected -> partiallySelected

* fix: useAntdTable determine if filters are equal change to a more robust method

* feat: add usePagination (#105)

* feat: add usePagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants