Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

对接istio 中MCP-OVER-XDS 这种方式有计划支持吗? #4856

Closed
ccwxl opened this issue Feb 2, 2021 · 5 comments
Closed

对接istio 中MCP-OVER-XDS 这种方式有计划支持吗? #4856

ccwxl opened this issue Feb 2, 2021 · 5 comments
Assignees
@lzp0412
Labels
area/Istio kind/feature type/feature
Milestone
2.0.1

Comments

@ccwxl
Copy link
Contributor

ccwxl commented Feb 2, 2021

  • 在今年五月份istio添加了 MCP-OVER-XDS的实现 ，在当前的master代码中已经 移除了mcp 协议 的实现代码，将全部转换为MCP-OVER-XDS实现，也就意味着istio 1.9将不再支持原有MCP协议，具体参考 XDS-OVER-MCP设计https://docs.google.com/document/d/1lHjUzDY-4hxElWN7g6pz-_Ws7yIPt62tmX3iGs_uLyI/edit#
  • nacos对此有计划支持吗?
@lzp0412
Copy link
Collaborator

lzp0412 commented Feb 2, 2021

@siaron 已经实现，最近会提交pr，下一个1.x版本会发布。

This was referenced Mar 16, 2021
Closed
Merged
@KomachiSion KomachiSion added the kind/feature type/feature label Mar 31, 2021
@KomachiSion KomachiSion added this to the 2.0.1 milestone Mar 31, 2021
KomachiSion pushed a commit that referenced this issue Mar 31, 2021
@lzp0412
[ISSUE #4856]support mcp over xds (#5124)
95194bd 
* support mcp over xds

* add some exclude for checkstyle and rat

* exclude some auto generate code for pmd checkstyle

* remove  redundancy property
@Xunzhuo
Copy link

Xunzhuo commented Aug 15, 2021

@lzp0412 我想了解一下，现在MoX的方案，是做的全量下发还是增量下发呢？

@devincd
Copy link

devincd commented Sep 8, 2021

结论：全量下发！

参考以下源代码的实现

func (a *ADSC) handleMCP(gvk []string, resources []*any.Any) {
}

由于涉及到资源的删除情况，目前源代码的做法是每次将内存中的资源和 mcp 中推送过来的资源做对比，假设某个资源内存中有，但是推送过来的资源没有的话，会触发删除这个资源的操作。

鉴于这个机制，所以目前做的都是全量下发。

@Xunzhuo
Copy link

Xunzhuo commented Sep 8, 2021

@devincd I see, thanks a lot.

@ccwxl
Copy link
Contributor Author

ccwxl commented Sep 8, 2021

这个目前支持的istio版本是多少?

@Matthelonianxl Matthelonianxl mentioned this issue Oct 17, 2022
Open
@Simplewyl2000 Simplewyl2000 mentioned this issue Oct 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzp0412 lzp0412

Labels
area/Istio kind/feature type/feature
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
5 participants
@devincd @lzp0412 @ccwxl @KomachiSion @Xunzhuo