Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4770] add grayscale release can  select client IP feature #4878

Closed
wants to merge 2 commits into from

Conversation

jiangxiaochuan
Copy link

@jiangxiaochuan jiangxiaochuan commented Feb 4, 2021

What is the purpose of the change

add grayscale release can  select client IP feature.
#4770

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


蒋小川 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/enhancement Category issues or prs related to enhancement. labels Feb 5, 2021
@KomachiSion KomachiSion added this to the 1.4.2 milestone Feb 5, 2021
@KomachiSion
Copy link
Collaborator

@jiangxiaochuan Please fix the git commit log and sign CLA.

your commit log user and email should same as your github id and email. otherwise github can not find and locate user right.

@KomachiSion KomachiSion removed this from the 1.4.2 milestone Mar 4, 2021
@KomachiSion
Copy link
Collaborator

Sorry @jiangxiaochuan , your cla has no sign for a long time, so I must close your PR. Please solve your cla problem and submit it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants