-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TemplateUtils usage #5010
fix TemplateUtils usage #5010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is no meaningful,
Reason is TemplateUtils.java will use isBlank and isEmpty to check source fist, if source is null, source.trim will not be called.
return TenantUtil.getUserTenantForAcm(); | ||
} | ||
}); | ||
namespaceTmp = TenantUtil.getUserTenantForAcm(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 160 String namespaceTmp = null , namespace is null here, stringBlankAndThenExecute is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 160 String namespaceTmp = null , namespace is null here, stringBlankAndThenExecute is redundant
When callable.call throw exception and source is null , npe will be throw. |
OK. |
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.