Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5078] add pageNo and pageSize param when to get subscribers on other server nodes #5099

Closed
wants to merge 1 commit into from

Conversation

wanghuigithub
Copy link

…get subscribers

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

to fix [ISSUE #5078]

Brief changelog

add param pageNo and pageSize at method com.alibaba.nacos.naming.core.SubscribeManager.getSubscribers

Verifying this change

the error is not occur

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [done ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ done] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [ done] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ done] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [ done] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wanghui02@kanzhun.com seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KomachiSion
Copy link
Collaborator

@wanghuigithub Please sign your CLA. your git commit log users is different with your github id. So CLA is not passed.

Please set your git user as your github id and email. And then re-submit a right PR. Thanks.

@haoyann
Copy link
Collaborator

haoyann commented Mar 15, 2021

Request other nodes to add paging parameters using the parameters of the current console, when I request the next page of data, there is a possibility of data loss.

@wanghuigithub
Copy link
Author

Request other nodes to add paging parameters using the parameters of the current console, when I request the next page of data, there is a possibility of data loss.

yes, the right way is to get all subscriber data from other node .
the pageNo should be set 1, the pageSize maybe a constant value such as 10000, but it's a little trick.
is there some better idea?

@haoyann
Copy link
Collaborator

haoyann commented Mar 16, 2021

Take out all the data, it is recommended to add query conditions according to subscriber IP. @KomachiSion @wanghuigithub What do you think.

@KomachiSion
Copy link
Collaborator

I think the best way is query local first, if local subscribers is enough to show current page, do not request other page.

If not enough, query one other node and do the check again.

But the way is a little complex, we can do it step by step, can fix problem by complex first.

@KomachiSion
Copy link
Collaborator

@wanghuigithub Please fix the CLA, otherwise we can't merge this PR.

@KomachiSion
Copy link
Collaborator

@wanghuigithub Sorry, you do not solve the CLA problem for a long time. So we have to close PR.

@KomachiSion KomachiSion added the status/invalid This doesn't seem right label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants