Color checker detection and correction update #1532
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demoulinv
force-pushed
the
dev/colorCheckerCorrection
branch
2 times, most recently
from
955fff3 to
802be54
Compare
Deal with images in a linear color space as input. Add a mode for only adjusting the image luminance. Compute an orientation info for every detected color checker. Option to select the best oriented color checker or combine them if several are detected.
… and full correction.
…ly for images with a name matching a filter. [hdr merging] Forward the suffix "_macbeth" to the hdr image name if at least one of the merged images has a name suffixed with that.
demoulinv
force-pushed
the
dev/colorCheckerCorrection
branch
from
802be54 to
077101a
Compare
Deal with images in a linear color space as input. Add a mode for only adjusting the image luminance. Compute an orientation info for every detected color checker. Option to select the best oriented color checker or combine them if several are detected.
… and full correction.
…ly for images with a name matching a filter. [hdr merging] Forward the suffix "_macbeth" to the hdr image name if at least one of the merged images has a name suffixed with that.
…olors
In some cases, the colors written in the JSON file of the detected checkers
can be set as "-nan". When that occurs, the value is not considered as a
"double", which raises a fatal issue ("cannot converted type to double").
Here, if the requested color value cannot be retrieved, or if it is not
a double, it will be set to 0 instead of stopping the program.
To prevent segmentation faults when attempting to access out of range pixels, we check that the location of the pixel is within the image.
fabiencastan
requested changes
Sep 21, 2023
cbentejac
force-pushed
the
dev/colorCheckerCorrection
branch
from
2d7dbf0 to
ff90b3d
Compare
…vision/AliceVision into dev/colorCheckerCorrection
…d detection using cnn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the color checker detection and correction to have a better processing of linear images, enable some new processing modes and combination of several color checkers detected in the same dataset.
linked to alicevision/Meshroom#2186
Features list
Implementation remarks