-
Notifications
You must be signed in to change notification settings - Fork 18
[Chat Completions] Response payload definition #22 (backup) #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chat Completions] Response payload definition #22 (backup) #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마지막 주석 다는 작업만 하면 끝날 것 같습니다!
src/AzureOpenAIProxy.ApiApp/Endpoints/ProxyChatCompletionsEndpoint.cs
Outdated
Show resolved
Hide resolved
모든 프로퍼티에 OpenAPI 문서에 있는대로 주석을 달고, description이 없는 경우에는 최소한의 설명을 추가하여 작성하였습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마지막 knit picking 입니다!
src/AzureOpenAIProxy.ApiApp/Models/CreateChatCompletionResponse.cs
Outdated
Show resolved
Hide resolved
수정하였습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나만 더!
src/AzureOpenAIProxy.ApiApp/Models/CreateChatCompletionResponse.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! LGTM!
Related to #22
백업하였습니다!
수정사항
await host.ResourceNotificationService.WaitForResourceAsync("apiapp", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30));
를 추가하였습니다.history : #237