Skip to content

Conversation

jhmin99
Copy link
Contributor

@jhmin99 jhmin99 commented Sep 2, 2024

Related to #22

백업하였습니다!

수정사항

  • ChatCompletionSchemasOpenApiTests에서 다른 Apphost tests들과 마찬가지로
    await host.ResourceNotificationService.WaitForResourceAsync("apiapp", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30)); 를 추가하였습니다.

history : #237

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 주석 다는 작업만 하면 끝날 것 같습니다!

@jhmin99
Copy link
Contributor Author

jhmin99 commented Sep 4, 2024

모든 프로퍼티에 OpenAPI 문서에 있는대로 주석을 달고, description이 없는 경우에는 최소한의 설명을 추가하여 작성하였습니다.

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 knit picking 입니다!

@jhmin99
Copy link
Contributor Author

jhmin99 commented Sep 6, 2024

마지막 knit picking 입니다!

수정하였습니다!

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나만 더!

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! LGTM!

@justinyoo justinyoo merged commit c8c1e83 into aliencube:main Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chat Completions] Response payload definition
2 participants