Skip to content

Use prebuild action that will create phpcs annotations #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use prebuild action that will create phpcs annotations #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b3756
Use prebuild action that will create phpcs annotations
jswift Nov 30, 2021
6a396e4
Add phpcs configuration file
jswift Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,6 @@ jobs:
run: composer run-script test

- name: Run linter to check code style
run: composer run-script check-style
uses: chekalsky/phpcs-action@v1
with:
enable_warnings: true
9 changes: 9 additions & 0 deletions .phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0"?>
<ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" name="PHP_CodeSniffer" xsi:noNamespaceSchemaLocation="phpcs.xsd">
<description>Coding standard configuration for the Bigcommerce V3 API Client.</description>

<file>src</file>
<file>tests</file>

<rule ref="PSR12"/>
</ruleset>
1 change: 1 addition & 0 deletions src/BigCommerce/Api/Catalog/BrandsApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class BrandsApi extends ResourceApi
private const BRAND_ENDPOINT = 'catalog/brands/%d';
private const BRANDS_ENDPOINT = 'catalog/brands';

public const DO_NOT_MERGE = "this because it's only to test the new phpcs github action with annotations. This line is clearly too long.";
public const FILTER_INCLUDE_FIELDS = 'include_fields';
public const FILTER_EXCLUDE_FIELDS = 'exclude_fields';

Expand Down