Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: diff cursor on folders while pressing alt key with checkbox opened #151

Merged
merged 3 commits into from
Feb 28, 2024
Merged

feat: diff cursor on folders while pressing alt key with checkbox opened #151

merged 3 commits into from
Feb 28, 2024

Conversation

liuycy
Copy link
Contributor

@liuycy liuycy commented Feb 24, 2024

refer to #148 (comment)

改动如下

  • 在显示多选框时，鼠标在文件夹上显示默认指针，按下 Alt 键时显示手势指针
  • 修复 Solidjs 的 on:* 使用原生事件时 typescript 会报错的问题

xhofe
xhofe requested changes Feb 27, 2024
View reviewed changes
src/hooks/useGlobalEvents.ts Outdated Show resolved Hide resolved
@liuycy liuycy requested a review from xhofe February 27, 2024 08:47
@xhofe xhofe merged commit 1687d11 into AlistGo:main Feb 28, 2024
4 checks passed
@anwen-anyi
Copy link
Contributor

anwen-anyi commented Feb 29, 2024 •
edited
Loading

  • 在复选框上打开项目
    • 列表模式：可以直接打开 ✅
    • 网格模式、图片模式：不能打开还是得使用Alt+点击 ❌

image

  • 在复选框上打开项目
    • 省略号、多行：生效 ✅
    • 滚动：不生效 ❌ ( 需要手机查看吗？ 手机也试了不行其它两个选项可以)

image

还要一个ctrl的按键选项是需要其它设备匹配吗？还是说后端需要更新 😹
image

@liuycy
Copy link
Contributor Author

liuycy commented Feb 29, 2024

滚动：不生效 ❌ ( 需要手机查看吗？ 手机也试了不行其它两个选项可以)

😂 看代码应该是加了横向滚动而已，电脑上可以按 shift 键 + 鼠标滚轮 进行滚动，手机上需要左右滑动

网格模式、图片模式：不能打开还是得使用Alt+点击 ❌

这个似乎没改全，我提个 PR 补充一下

@liuycy liuycy mentioned this pull request Feb 29, 2024
Merged
@liuycy liuycy deleted the cursor branch March 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhofe xhofe xhofe approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuycy @anwen-anyi @xhofe