List core file #75
Merged
List core file #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzifa
force-pushed
the
list-core-file
branch
from
25713a3 to
c4e7d05
Compare
JacksonTian
requested changes
Apr 3, 2018
lib/orders/list_core.js
Outdated
| exports.coredir = []; | ||
| coreFileNamePrefix = 'core'; | ||
| var patt = fs.readFileSync('/proc/sys/kernel/core_pattern', 'utf8').trim().split(' ')[0]; | ||
| if (patt.indexOf('%') > 0) { |
lib/orders/list_core.js
Outdated
|
|
||
| for (var i = 0; i < count; i++) { | ||
| getNodePWD(pids[i], done); | ||
| } |
| var done = function(err, pwd) { | ||
| finished++; | ||
| if (pwd && pwds.indexOf(pwd) === -1) { | ||
| pwds.push(pwd); |
There was a problem hiding this comment.
if (pwd && pwds.indexOf(pwd) === -1) 这句去重的
|
我们只对新产生的 core 文件进行上报吧。可能要根据文件生成的时间来过滤。 |
zhangzifa
force-pushed
the
list-core-file
branch
2 times, most recently
from
7eb1eb8 to
9c95846
Compare
|
测试没有过？ |
zhangzifa
force-pushed
the
list-core-file
branch
from
9c95846 to
4590b7b
Compare
JacksonTian
approved these changes
Apr 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check core files
1. if user specified "coredir": [dir1, dir2], or
2. /proc/sys/kernel/core_pattern is something like /tmp/coredump_%d_%P, or
3. by default