Skip to content

Conversation

doronzuk
Copy link

@doronzuk doronzuk commented Mar 1, 2020

added class to support request for DescribeFileSystemStatistics.
this is supported in openAPI but is not implemented in any of the SDKs

@codecov-io
Copy link

codecov-io commented Mar 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6e548b8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #315   +/-   ##
=========================================
  Coverage          ?   43.49%           
=========================================
  Files             ?      141           
  Lines             ?     9784           
  Branches          ?     1553           
=========================================
  Hits              ?     4256           
  Misses            ?     5248           
  Partials          ?      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e548b8...84686b3. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@doronzuk
Copy link
Author

doronzuk commented Mar 4, 2020

@samuelchen, @suzaku can you please take a look, only missing 2 reviewers

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@samuelchen samuelchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to me

@doronzuk
Copy link
Author

doronzuk commented Mar 8, 2020

@samuelchen , @suzaku so we have 2 reviews? can we merge?

@JacksonTian
Copy link
Contributor

The code was auto-generated, next time will overwrite your commits. I will notice the NAS team to update the SDK.

@JacksonTian JacksonTian closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants