Skip to content

Conversation

yami
Copy link
Contributor

@yami yami commented Mar 29, 2016

…delete the record; set connection pool size correctly; close connections for APIs which do not read body.

yami added 2 commits March 29, 2016 18:06
…delete the record; set connection pool size correctly; close connections for APIs which do not read body.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 98.059% when pulling 65ea1f6 on con-multipart into 4b1456e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 98.055% when pulling 6e0938d on con-multipart into 4b1456e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.05% when pulling 2cc9804 on con-multipart into 4b1456e on master.

@rockuw
Copy link
Contributor

rockuw commented Mar 30, 2016

其他情况也有需要删除record的吗?比如source object发生了变化。

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.05% when pulling 2cc9804 on con-multipart into 4b1456e on master.

@yami
Copy link
Contributor Author

yami commented Mar 30, 2016

source object变化的场景已经cover了。

@rockuw
Copy link
Contributor

rockuw commented Mar 30, 2016

如果temp文件存在,但是其中的内容已经被改变了呢?

@yami
Copy link
Contributor Author

yami commented Mar 30, 2016

这个暂时没有cover,也不期望用户这样做。用户也完全可以修改record之类的。

@rockuw
Copy link
Contributor

rockuw commented Mar 30, 2016

+1

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 97.993% when pulling 2cc9804 on con-multipart into 4b1456e on master.

@yami yami merged commit f72cd78 into master Mar 30, 2016
@yami yami deleted the con-multipart branch March 30, 2016 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants