-
Notifications
You must be signed in to change notification settings - Fork 5
Extended default callouts for new journeys #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@techsmyth to check! can't make you reviewer as you created the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are indeed very nice but will be felt by like 1% of the cases unless we have a data migration, check whether this data exists, and if not - add it.
@valentinyanakiev afraid not our rights to add them into existing spaces etc. but we can add callout templates to the library to make them more accessible & maybe do some handholding with key spaces… |
@valentinyanakiev please bring this one down to develop if it is working ok. The story about getting existing spaces / challenges updated should be raised as a separate story - and it is a non-trivial one as we cannot just go and modify existing spaces / challenges with new data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These templates fail the most basic test - creating a Space:
{
"errors": [
{
"message": "Please provide a whiteboard",
"locations": [
{
"line": 2,
"column": 3
}
],
"path": [
"createSpace"
],
"extensions": {
"code": "INTERNAL_SERVER_ERROR",
"exception": {
"stacktrace": [
"Error: Please provide a whiteboard",
" at CalloutService.createCallout (/home/valentin/work/repos/alkemio/server/src/domain/collaboration/callout/callout.service.ts:90:13)",
" at CollaborationService.addDefaultCallouts (/home/valentin/work/repos/alkemio/server/src/domain/collaboration/collaboration/collaboration.service.ts:102:49)",
" at processTicksAndRejections (node:internal/process/task_queues:96:5)",
" at SpaceService.createSpace (/home/valentin/work/repos/alkemio/server/src/domain/challenge/space/space.service.ts:141:27)",
" at SpaceResolverMutations.createSpace (/home/valentin/work/repos/alkemio/server/src/domain/challenge/space/space.resolver.mutations.ts:70:19)"
]
}
}
}
],
"data": null
}
@larssondenise I'd expect this to be tested locally before this is moved to review:
- creating a new space
- creating a new challenge inside a new / old space
- creating a new opportunity inside a new / old challenge
@valentinyanakiev they should now be creating ok. |
@techsmyth A super quick test and it fails on the first attempt:
Maybe I should have mentioned - please, after creating the Journeys, try to open them. It fails on every level. |
@valentinyanakiev ok I thought I had done that but clearly missed something. @alstojanovic as Valentin is away tomorrow can you please take a look at the latest fix? |
Sure, will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested crating space, challenge and opportunity. Default callouts are in place in regards to new changes.
Describe the background of your pull request
What does your pull request do? Does it solve a bug (which one?), add a feature?
Additional context
Add any other context
Governance
By submitting this pull request I confirm that:
https://github.com/alkem-io/Coordination/blob/master/LICENSE.