Optimization of data loading on auth reset #4489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e; updated method signature to only take a profileID, not the whole profile
hero101
requested changes
Aug 29, 2024
src/domain/common/authorization-policy/authorization.policy.service.ts
Outdated
Show resolved
Hide resolved
hero101
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the data that is loaded around Profiles.
Also done for CalloutFraming, CalloutContribution and User entity.
Further optimization possible but this relatively small set of changes is showing some good results. On my local machine:
Suspect the win is across the board. More to be had, but given the above results thought it already interesting to push this, even if is just a very rough measure of performance impact.