Skip to content

Subspace templates fixes 3 #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Subspace templates fixes 3 #4671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c579e84
0.95.1
ccanos Nov 5, 2024
9a57cd0
Fix visibility (all are DRAFT) of callouts on bootstrap
ccanos Nov 5, 2024
aa4b31a
Fix: Delete collaboration template not working
ccanos Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "alkemio-server",
"version": "0.95.0",
"version": "0.95.1",
"description": "Alkemio server, responsible for managing the shared Alkemio platform",
"author": "Alkemio Foundation",
"private": false,
Expand Down
8 changes: 8 additions & 0 deletions ...strap/platform-template-definitions/space-tutorials/bootstrap.space.tutorials.callouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { CalloutGroupName } from '@common/enums/callout.group.name';
import { TagsetReservedName } from '@common/enums/tagset.reserved.name';
import { FlowState } from './bootstrap.space.tutorials.innovation.flow.states';
import { CreateCalloutInput } from '@domain/collaboration/callout/dto/callout.dto.create';
import { CalloutVisibility } from '@common/enums/callout.visibility';

export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
{
Expand All @@ -15,6 +16,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '👋 Welcome to your space!',
Expand All @@ -37,6 +39,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 2,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '⚙️ Set it up your way!',
Expand All @@ -59,6 +62,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 3,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '🧩 Collaboration tools',
Expand All @@ -81,6 +85,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 4,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '🧹 Cleaning up',
Expand All @@ -103,6 +108,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.COMMUNITY,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '🤝 Set up your Community',
Expand All @@ -125,6 +131,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.SUBSPACES,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '↪️ Subspaces',
Expand All @@ -147,6 +154,7 @@ export const bootstrapSpaceTutorialsCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.KNOWLEDGE,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '📚 The Knowledge Base',
Expand Down
2 changes: 2 additions & 0 deletions src/core/bootstrap/platform-template-definitions/space/bootstrap.space.callouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { CalloutGroupName } from '@common/enums/callout.group.name';
import { TagsetReservedName } from '@common/enums/tagset.reserved.name';
import { FlowState } from './bootstrap.space.innovation.flow';
import { CreateCalloutInput } from '@domain/collaboration/callout/dto/callout.dto.create';
import { CalloutVisibility } from '@common/enums/callout.visibility';

export const bootstrapSpaceCallouts: CreateCalloutInput[] = [
{
Expand All @@ -15,6 +16,7 @@ export const bootstrapSpaceCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '👋 Welcome to your space!',
Expand Down
12 changes: 12 additions & 0 deletions ...platform-template-definitions/subspace-knowledge/bootstrap.subspace.knowledge.callouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { CalloutType } from '@common/enums/callout.type';
import { TagsetReservedName } from '@common/enums/tagset.reserved.name';
import { FlowState } from './bootstrap.subspace.knowledge.innovation.flow.states';
import { CreateCalloutInput } from '@domain/collaboration/callout/dto/callout.dto.create';
import { CalloutVisibility } from '@common/enums/callout.visibility';

export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
{
Expand All @@ -14,6 +15,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'No Time? A quick summary ⬇️',
Expand All @@ -36,6 +38,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 2,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'The Virtual Contributor',
Expand All @@ -58,6 +61,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 3,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Interacting with a Virtual Contributor',
Expand All @@ -80,6 +84,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 4,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'The Profile of your Virtual Contributor',
Expand All @@ -102,6 +107,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 5,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Types of Content',
Expand All @@ -124,6 +130,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 6,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Terms & Conditions',
Expand All @@ -146,6 +153,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 7,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Example 1: Background information',
Expand All @@ -168,6 +176,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 8,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Example 2: Random facts and figures',
Expand All @@ -190,6 +199,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 9,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Example 3: Links and Documents',
Expand All @@ -212,6 +222,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 10,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Where to find the Virtual Contributor Profile',
Expand All @@ -234,6 +245,7 @@ export const bootstrapSubspaceKnowledgeCallouts: CreateCalloutInput[] = [
},
sortOrder: 11,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: 'Updating my Body of Knowledge',
Expand Down
3 changes: 3 additions & 0 deletions src/core/bootstrap/platform-template-definitions/subspace/bootstrap.subspace.callouts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { CalloutType } from '@common/enums/callout.type';
import { TagsetReservedName } from '@common/enums/tagset.reserved.name';
import { FlowState } from './bootstrap.subspace.innovation.flow.states';
import { CreateCalloutInput } from '@domain/collaboration/callout/dto/callout.dto.create';
import { CalloutVisibility } from '@common/enums/callout.visibility';

export const bootstrapSubspaceCallouts: CreateCalloutInput[] = [
{
Expand All @@ -14,6 +15,7 @@ export const bootstrapSubspaceCallouts: CreateCalloutInput[] = [
},
sortOrder: 1,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName: '👋 Welcome to your subpace!',
Expand All @@ -37,6 +39,7 @@ export const bootstrapSubspaceCallouts: CreateCalloutInput[] = [
},
sortOrder: 2,
groupName: CalloutGroupName.HOME,
visibility: CalloutVisibility.PUBLISHED,
framing: {
profile: {
displayName:
Expand Down
6 changes: 4 additions & 2 deletions src/domain/collaboration/collaboration/collaboration.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ export class CollaborationService {

if (
!collaboration.callouts ||
!collaboration.timeline ||
!collaboration.innovationFlow ||
!collaboration.authorization
)
Expand All @@ -361,7 +360,10 @@ export class CollaborationService {
await this.calloutService.deleteCallout(callout.id);
}

await this.timelineService.deleteTimeline(collaboration.timeline.id);
if (collaboration.timeline) {
// There's no timeline for collaboration templates
await this.timelineService.deleteTimeline(collaboration.timeline.id);
}

await this.authorizationPolicyService.delete(collaboration.authorization);

Expand Down