Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple marathon apps with same consul service name #72

Closed
janisz opened this issue Apr 12, 2016 · 1 comment · Fixed by #73
Closed

Support multiple marathon apps with same consul service name #72

janisz opened this issue Apr 12, 2016 · 1 comment · Fixed by #73
Assignees
@janisz

Comments

@janisz
Copy link
Contributor

janisz commented Apr 12, 2016

Currently README states

Every marathon application needs to have a unique service name in Consul.

We should handle this case, because it could be used for green blue deployment.

Changes are required in deregisterAllAppServices to deregister only tasks for this app
@janisz janisz self-assigned this Apr 12, 2016
@dankraw
Copy link
Contributor

dankraw commented Apr 12, 2016

related to #42 and #35

janisz added a commit that referenced this issue Apr 12, 2016
@janisz
Fixes #72 | Unregister only tasks for given apps
2a3d2bb
@janisz janisz mentioned this issue Apr 12, 2016
Merged
janisz added a commit that referenced this issue Apr 13, 2016
@janisz
Fixes #72 | Unregister only tasks for given apps
8a1e0b6
janisz added a commit that referenced this issue Apr 13, 2016
@janisz
Fixes #72 | Unregister only tasks for given apps
9123639
janisz added a commit that referenced this issue Apr 22, 2016
@janisz
Merge pull request #73 from allegro/fixes_#72_unregister_only_tasks_f…
9843a5d 
…or_given_apps

Fixes #72 | Unregister only tasks for given apps
janisz added a commit that referenced this issue Apr 22, 2016
@janisz
Update README according to #72
5f72fff
janisz added a commit that referenced this issue Apr 22, 2016
@janisz
Update README according to #72
b4d1c1f
janisz added a commit that referenced this issue Apr 22, 2016
@janisz
Merge pull request #79 from allegro/update_readme_#72
6df975d 
Update README according to #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janisz janisz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #72 | Unregister only tasks for given apps allegro/marathon-consul
3 participants
@janisz @dankraw @adamdubiel