Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple marathon apps with same consul service name #72

Closed
janisz opened this issue Apr 12, 2016 · 1 comment · Fixed by #73
Closed

Support multiple marathon apps with same consul service name #72

janisz opened this issue Apr 12, 2016 · 1 comment · Fixed by #73
Assignees

Comments

@janisz
Copy link
Contributor

janisz commented Apr 12, 2016

Currently README states

Every marathon application needs to have a unique service name in Consul.

We should handle this case, because it could be used for green blue deployment.

Changes are required in deregisterAllAppServices to deregister only tasks for this app

@janisz janisz self-assigned this Apr 12, 2016
@dankraw
Copy link
Contributor

dankraw commented Apr 12, 2016

related to #42 and #35

janisz added a commit that referenced this issue Apr 22, 2016
…or_given_apps

Fixes #72 | Unregister only tasks for given apps
janisz added a commit that referenced this issue Apr 22, 2016
janisz added a commit that referenced this issue Apr 22, 2016
janisz added a commit that referenced this issue Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants