Fixes #72 | Unregister only tasks for given apps #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
You can update the readme as well. :) |
|
OK, I tested it and there are issues when deregistering services after app removal. :( |
janisz
force-pushed
the
fixes_#72_unregister_only_tasks_for_given_apps
branch
from
2a3d2bb
to
8a1e0b6
Compare
|
My bad, missing |
janisz
force-pushed
the
fixes_#72_unregister_only_tasks_for_given_apps
branch
from
8a1e0b6
to
9123639
Compare
|
It works great now! :) |
|
We can remove |
|
I create new pr for README update #79 |
|
cool thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intorduce logic in killing stoped application. Only tasks from killed/stoped application will be deregistered.
This fixes #72 #35 #42