Forcing a refresh when opening calendar filter. #527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What calendar data goes out of sync? |
Available date range. |
|
Please, provide full description of the issue because I don't know what problem is this PR trying to solve. |
|
Apologies, extended example added to my initial comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers the case when when Turnilo is opened for a longer time without auto update applied. Calendar data can be out of sync with Druid. Opening the filter tab will, now, force a refresh.
Example:
Open a Data Cube view, add Time to FILTER and make sure that Auto Update is set to OFF. Wait until Druid side data is updated - so its available time range is increased by a day. In Turnilo, click on the time filter, go to Fixed and observe the calendar - it won't reflect the actual state of the Data Cube, i.e. new time range - day from which the new data comes will be greyed out. It would make sense for the calendar component to try and get latest available timekeeper data when it's being displayed.
This will also happen with smaller time units like hours etc.