Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfills bundle #854

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Polyfills bundle #854

merged 1 commit into from
Feb 28, 2022

Conversation

plesiecki
Copy link
Collaborator

@plesiecki plesiecki commented Feb 25, 2022 •
edited
Loading

#845 (comment)

Modern browser will not fetch, parse and execute polyfills code.

@plesiecki plesiecki mentioned this pull request Feb 25, 2022
Open
12 tasks
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

1 similar comment
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the polyfill-bundle branch 3 times, most recently from b843b3e to 14f6ac9 Compare February 25, 2022 13:25
@plesiecki plesiecki changed the title Polyfills bundle ES6 bundle Feb 25, 2022
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki force-pushed the polyfill-bundle branch 2 times, most recently from 3da84c9 to 92b6b8a Compare February 25, 2022 13:30
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

1 similar comment
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

2 similar comments
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

@plesiecki plesiecki changed the title ES6 bundle Polyfills bundle Feb 28, 2022
@plesiecki plesiecki marked this pull request as ready for review February 28, 2022 09:25
@github-actions
Copy link

✅ Deployed successfully to: https://turnilo-polyfill-bundle-gmbbyye42a-ew.a.run.app

adrianmroz-allegro
adrianmroz-allegro reviewed Feb 28, 2022
View reviewed changes
config/webpack.common.js
@@ -33,7 +33,7 @@ module.exports = {
devtool: "source-map",
output: {
path: path.resolve(__dirname, '../build/public'),
filename: "main.js",
filename: "[name].js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is [name] resolved to key name in entry map?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, that's right

@plesiecki plesiecki merged commit ec838f9 into master Feb 28, 2022
@plesiecki plesiecki deleted the polyfill-bundle branch February 28, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

@kzadurska kzadurska kzadurska approved these changes

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plesiecki @kzadurska @adrianmroz-allegro