Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity 2020.3.25 w/ CloudRendering Engine #1002

Merged
merged 81 commits into from
Mar 29, 2022
Merged

Conversation

ekolve
Copy link

@ekolve ekolve commented Mar 17, 2022

This PR upgrades the version of Unity to 2020.3.25 and also adds the CloudRendering (headless rendering).

Eric Kolve added 30 commits April 23, 2021 20:28
…ormatter to handle non-IL2CPP serialization
Copy link
Collaborator

@winthos winthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

if not sys.platform.startswith("darwin"):
raise Exception("CloudRendering Engine can only be installed on Mac")
s3 = boto3.resource("s3")
target_base_dir = "/Applications/Unity/Hub/Editor/{}/PlaybackEngines".format(_unity_version())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps using the _unity_path() function here to not have multiple places to change if this string changes.

@AlvaroHG
Copy link
Collaborator

One minor comment, LGTM. Awesome to have CloudRendering support!

Copy link
Collaborator

@mattdeitke mattdeitke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have tested it with the unreleased updates, and all is well :)

@ekolve ekolve merged commit d9d38c7 into main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants