-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity 2020.3.25 w/ CloudRendering Engine #1002
Conversation
…ormatter to handle non-IL2CPP serialization
…ately before sending renderPayload
…cs card is used which results in inconsistent results with Metal
…nputfield (for webgl); updating webgl build filenames for 2020.3.25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
if not sys.platform.startswith("darwin"): | ||
raise Exception("CloudRendering Engine can only be installed on Mac") | ||
s3 = boto3.resource("s3") | ||
target_base_dir = "/Applications/Unity/Hub/Editor/{}/PlaybackEngines".format(_unity_version()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps using the _unity_path()
function here to not have multiple places to change if this string changes.
One minor comment, LGTM. Awesome to have CloudRendering support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, have tested it with the unreleased updates, and all is well :)
This PR upgrades the version of Unity to 2020.3.25 and also adds the CloudRendering (headless rendering).