Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] make 7702 auth recovery fallible #1068

Closed
mattsse opened this issue Jul 16, 2024 · 0 comments · Fixed by #1082
Closed

[Feature] make 7702 auth recovery fallible #1068

mattsse opened this issue Jul 16, 2024 · 0 comments · Fixed by #1082
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Jul 16, 2024

Component

consensus, eips, genesis

Describe the feature you would like

7702 auths are validated at evm runtime and are allowed to be fallible:

/// A recovered authorization.
#[derive(Debug, Clone, Hash, Eq, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct RecoveredAuthorization {
#[cfg_attr(feature = "serde", serde(flatten))]
inner: Authorization,
authority: Address,
}

TODO

  • support failed recovery with a new enum RecoveredAuthority {Valid(Address), Invalid}
  • document authority can be invalid

this is basically reverting #1047 but replacing the option with a new dedicated enum that behaves as an option

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant