chore: move define_udt! decl macro to sol! proc macro #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Dec 29, 2023
crates/sol-macro/src/expand/udt.rs
Outdated
| #[inline] | ||
| fn type_check(token: &Self::Token<'_>) -> ::alloy_sol_types::Result<()> { | ||
| <#underlying as ::alloy_sol_types::SolType>::type_check(token)?; | ||
| ::alloy_sol_types::private::just_ok(token) |
There was a problem hiding this comment.
If you don't mind, I think we can keep the user input with a #[sol(type_check = "function_name")] attribute. Otherwise I'll open an issue after.
There was a problem hiding this comment.
ok, should be done here e7e7b8f PTAL
fgimenez
force-pushed
the
chore/move-define-udt
branch
from
e7e7b8f
to
dbff597
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #39
Solution
Follows the suggestion here #39 (comment), just moves the
define_udt!content to proc macro in udt'sexpandfunction usingquote!.Besides moving the code I've used
expand_type(ty)as#underlyingand hardcoded::alloy_sol_types::private::just_okinstead of$path, let me know if that's ok. I've also added#[automatically_derived]annotations.PR Checklist