Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow function bodies in function parser #58

Closed
wants to merge 1 commit into from

Conversation

prestwich
Copy link
Member

unsure if this breaks anything

@prestwich prestwich requested a review from DaniPopes May 31, 2023 17:09
@prestwich prestwich added the enhancement New feature or request label May 31, 2023
@DaniPopes
Copy link
Member

I didn't originally add it because it would create confusion, given that we will ignore anything inside of the block anyway. Was aiming for a interface rather than contract, which does not allow function blocks in Solidity, but without the other limitations like only external functions etc.

Also you'll have to bless the tests with env TRYBUILD=overwrite

@prestwich
Copy link
Member Author

I didn't originally add it because it would create confusion, given that we will ignore anything inside of the block anyway. Was aiming for a interface rather than contract, which does not allow function blocks in Solidity, but without the other limitations like only external functions etc.

yeah, I am wondering if we eventually want to get to the point where we expand entire solidity files. this is just playing around in that direction, basically

@prestwich
Copy link
Member Author

closing this as stale. we can pick it up again later if we want

@prestwich prestwich closed this Jun 9, 2023
@DaniPopes DaniPopes deleted the prestwich/function-body branch June 21, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants