Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 'listen' gem #23

Merged
merged 2 commits into from
Jun 11, 2012
Merged

Use the 'listen' gem #23

merged 2 commits into from
Jun 11, 2012

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jun 11, 2012

These commits make kicker use the 'listen' gem, allowing it to work on Linux as well.

Fixes issue #7.

Caveat: Not tested on MacOS X.

mvz added 2 commits June 8, 2012 14:02
Listen uses the appropriate file system watcher library under the hood.

Since listen passes files instead of directories to the callback block,
there is some superfluous conversion of files to directories to files.
This could be streamlined.
@alloy
Copy link
Owner

alloy commented Jun 11, 2012

Sweet, this looks really nice. I will ask the guys at the office to use this for a while and we'll see if any issues crop up or release otherwise.

cc @Manfred @jeffkreeftmeijer

alloy added a commit that referenced this pull request Jun 11, 2012
@alloy alloy merged commit f73695f into alloy:master Jun 11, 2012
@alloy alloy mentioned this pull request Jun 11, 2012
@alloy
Copy link
Owner

alloy commented Jun 11, 2012

I did not even remember that Kicker was on Travis as well… :)

There is at least one small syntax error on 1.8.7.

@alloy
Copy link
Owner

alloy commented Jun 12, 2012

Just pushed 2.6.0.rc1, install it with:

$ gem install kicker --pre

If no issues crop up, then I’ll release this somewhere next week.

@mvz
Copy link
Contributor Author

mvz commented Jun 15, 2012

Cool. It works for me :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants