Rft build config #673
Rft build config #673
Conversation
github-actions
bot
added
theme:assertj
|
@vlsi could you please review, sir? |
| clean = true | ||
| resultsDirs = subprojects.map { file("${it.buildDir}/allure-results") }.filter { it.exists() } | ||
| repositories { | ||
| mavenLocal() |
There was a problem hiding this comment.
Is it worth adding mavenLocal by default? It makes the build non-reproducible
There was a problem hiding this comment.
we should be fine. Haven't seen any issues
There was a problem hiding this comment.
Why do you add it?
It is a time bomb: developers might have unknown jars in mavenLocal repo, so consuming from mavenLocal leads to non-reproducible results.
If you really need mavenLocal for some reason, consider adding a property so mavenLocal is added only in case user explicitly opts-in.
There was a problem hiding this comment.
isn't it better to use https://docs.gradle.org/current/userguide/dependency_verification.html for such cases?
There was a problem hiding this comment.
Why adding mavenLocal though? By the way, Gradle always checks jars (if they have proper contents) in .m2 even in case mavenLocal() is not mentioned, so mavenLocal() does NOT make the build faster. However, it makes the build less reliable, so it is better to avoid mavenLocal by default.
There was a problem hiding this comment.
nah, I just always committing it accidentally with an other changes. It's only needed to develop a new feature/integration against some snapshot dependency (or even when I plan to patch some framework or so)
And, as is was there forever (and not only there -- as far as I remember maven uses it always by default) I feel a bit sceptical about removing it just because some bad thing could probably happen in future
|
Looks good. Do you mean the agent is added by allure-gradle plugin? |
yep. Encountered few issues with it though
|
| @@ -215,6 +215,17 @@ configure(libs) { | |||
| } | |||
| } | |||
|
|
|||
| allure { | |||
| adapter { | |||
| autoconfigure.set(false) | |||
There was a problem hiding this comment.
because we use junit platform to test other test frameworks in most cases.
ghost
mentioned this pull request
ghost
mentioned this pull request
Context
Checklist