Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPUnit allure adapter conflicting with Codeception allure adapter #41

Closed
okolesnyk opened this issue Dec 12, 2018 · 1 comment
Closed

PHPUnit allure adapter conflicting with Codeception allure adapter #41

okolesnyk opened this issue Dec 12, 2018 · 1 comment

Comments

@okolesnyk
Copy link
Contributor

okolesnyk commented Dec 12, 2018 •
edited
Loading

Problem

If any project will require two allure-framework packages (in our case allure-phpunit and allure-codeception) we will have two classes which have identical full class name: Yandex\Allure\Adapter\AllureAdapter.
It will cause an issue for autoloader to load appropriate adaptor for codeception and phpunit.

Suggestion

Make namespace unique.
For example:
Yandex\Allure\Codeception\Adapter\AllureAdapter
Yandex\Allure\PHPUnit\Adapter\AllureAdapter

Or class name unique

Yandex\Allure\Adapter\CodeceptionAllureAdapter
Yandex\Allure\Adapter\PHPUnitAllureAdapter

Related Issue

allure-framework/allure-codeception#44
@okolesnyk okolesnyk mentioned this issue Dec 12, 2018
Closed
okolesnyk added a commit to okolesnyk/allure-phpunit that referenced this issue Dec 12, 2018
@okolesnyk
Resolves allure-framework#41
4852990 
 - PHPUnit allure adapter conflicting with Codeception allure adapter
@okolesnyk okolesnyk mentioned this issue Dec 12, 2018
Merged
@okorshenko
Copy link

Thank you for submitting PR for this issue! 👍

okolesnyk added a commit to okolesnyk/allure-phpunit that referenced this issue Dec 17, 2018
@okolesnyk
Resolves allure-framework#41
ffbda1f 
 - PHPUnit allure adapter conflicting with Codeception allure adapter
 - Code review changes
@baev baev closed this as completed in 8c59b72 Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okorshenko @okolesnyk