fix: crypto implementations not being compiled #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the
LIBSSH2_CRYPTO_C
ifdef at the top of src/openssl.c, src/mbedtls.c, src/libgcrypt.c, src/wincng.c these crypto backends couldn't be used.It would fail with these kinds of error:
FYI. After some additional investigating I noticed that this
LIBSSH2_CRYPTO_C
ifdef doesn't exist in the master branch of libssh2. Because it was removed with this commit libssh2/libssh2@e0681cd. So when upgrading past libssh2-1.11.1 this part will need to be updated again.Maybe as a future improvement CI/CD needs to be setup for this, so this kind of bug doesn't reoccur?