-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make filters easier to use and pitchshift filter #110
Conversation
For this PR we should think about the version to choose, the check fails on CHANGELOG.md which doesn't have it. On pub.dev this plugin has not been updated to the main branch since PR 85 so we may think of releasing 2.1.0 or a major 3.0 since the news are important. For this review, regarding the new filters' way to manage them, in the
update: I have fixed the CHANGELOG just to see if this PR is mergeable |
LGTM! Thanks! |
Also verified the examples on macOS. Love the new |
Description
Removed the main example which was too much complicate for a first approach. In the futere I'll make a new GitHub repository with that.
For now there are 2 little example:
Added
pitch shift
filter to somehow resolve #98.This filter has these parameters:
shift
: a value of 0.5 means one octave down (12 semitones down), a value of 2.0 means one octave up (12 semitones up).semitones
: increases or decrease using semitones (¹/12 of an octave).This filter can be used in conjunction with
SoLoud.setRelativePlaySpeed()
to for example play a sound with voices at double speed without changing the tone speech.The filters can now be used for single sounds instead of using them only globally.
IMPORTANT: filters for individual sounds are not supported on the
web platform. On the other platforms the filter must be added before playing. Only voice handles played after adding the filter will play with the filter chosen.
Filters can now be accessed globally using
SoLoud.instance.filters
or for single [AudioSource] sounds withsound.filters
to resolve #108. With something like:Look at the respective documentation to see how to use them.
Type of Change